Allow specifying a proxy for http API connections #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpalang
requested changes
Nov 3, 2025
Contributor
kpalang
left a comment
kpalang
left a comment
There was a problem hiding this comment.
Looks good in general.
One small things is I would like to see a log about the usage of a proxy. Possibly at INFO level since OIE logs at ERROR by default.
kpalang
requested review from
a team,
gibson9583,
kayyagari,
kpalang and
pacmano1
and removed request for
a team
Contributor
Author
|
@kpalang, added info log message. |
kpalang
previously approved these changes
Nov 7, 2025
tonygermano
requested changes
Nov 13, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
A couple suggestions:
- I would like to avoid adding something new containing "mirth." How about
oie.client.api.http.proxyHostandoie.client.api.http.proxyPortfor the property names? - Create some
private finalfields in the class to hold the property names rather than referencing them directly in the code. - Assuming this will all be squashed to one commit at the end, flesh out the commit message to include why this is being added and example usage. Add a trailer linking it to the issue. I usually do this by just typing at the end
Issue: <full URL to github issue>so it shows up just above the sign-off.
Adds support for the client to connect to the server via an HTTP proxy. Client examines the engine.http.proxyHost and engine.http.proxyPort system properties to determine the proxy to use. Closes OpenIntegrationEngine#190 in OIE Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
feature/add-proxy-support
branch
from
e96f62d to
4681156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying a proxy for http API connections via mirthApi.http.proxyHost.
Example invocation:
-DmirthApi.http.proxyHost=127.0.0.1. Example file attached showing login with no channels.Example with Fiddler:
Closes #190